Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a RenderFragment/ChildContent factory method that takes a RenderFragment as input #142

Closed
egil opened this issue Jun 5, 2020 · 1 comment · Fixed by #203
Closed

Add a RenderFragment/ChildContent factory method that takes a RenderFragment as input #142

egil opened this issue Jun 5, 2020 · 1 comment · Fixed by #203
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v1.0.0

Comments

@egil
Copy link
Member

egil commented Jun 5, 2020

The ComponentParameterFactory should have a RenderFragment and ChildContent method with the following signature:

public static ComponentParameter RenderFragment(string name, RenderFragment fragment);
public static ComponentParameter ChildContent(RenderFragment fragment);

This will enable more complex scenarios where any valid render fragment can be passed to a RenderFragment or ChildContent parameter.
@egil egil added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 5, 2020
@egil egil added this to the beta-8 milestone Jun 5, 2020
@egil
Copy link
Member Author

egil commented Jun 26, 2020

Related to #140

@egil egil modified the milestones: beta-8, v1.0.0 Jul 29, 2020
@egil egil linked a pull request Sep 4, 2020 that will close this issue
Improvements to parameter passing #203
Merged
14 tasks
egil added a commit that referenced this issue Sep 6, 2020
@egil
Finished component parameter collection, closed #142, updated tests t…
cc1b1cc 
…o component parameter factory
@egil egil mentioned this issue Sep 11, 2020
Merged
14 tasks
egil added a commit that referenced this issue Sep 22, 2020
@egil
Finished component parameter collection, closed #142, updated tests t…
26afc85 
…o component parameter factory
egil added a commit that referenced this issue Sep 27, 2020
@egil @actions-user
Improvements to parameter passing in c# based tests (#203)
b78098c 
* componentparametercollection

* Support for passing multiple template and render fragments

* Automated dotnet-format update

* cascading values

* Finished component parameter collection, closed #142, updated tests to component parameter factory

* Fixed null warnings

* Automated dotnet-format update

* Fixes for CodeQL warnings

* Added ChildContent and RenderFragment tests

* Added support for passing template fragments

* Removed ComponentParameterBuilder, added support for unmatched and cascading values

* Switched to C# 9 compile

* Automated dotnet-format update

* unnamed cascading value with add

* Removed .net move hack from workflows

* Fix for null errors

* Automated dotnet-format update

* Added extra factory method and moved ComponentParameter out into Bunit namespace

* Updated docs with new parameter passing logic

* Automated dotnet-format update

* Updated changelog

Co-authored-by: Github Actions <[email protected]>
@egil egil closed this as completed Sep 27, 2020
egil added a commit that referenced this issue Oct 1, 2020
@egil @actions-user
Improvements to parameter passing in c# based tests (#203)
7aba4c7 
* componentparametercollection

* Support for passing multiple template and render fragments

* Automated dotnet-format update

* cascading values

* Finished component parameter collection, closed #142, updated tests to component parameter factory

* Fixed null warnings

* Automated dotnet-format update

* Fixes for CodeQL warnings

* Added ChildContent and RenderFragment tests

* Added support for passing template fragments

* Removed ComponentParameterBuilder, added support for unmatched and cascading values

* Switched to C# 9 compile

* Automated dotnet-format update

* unnamed cascading value with add

* Removed .net move hack from workflows

* Fix for null errors

* Automated dotnet-format update

* Added extra factory method and moved ComponentParameter out into Bunit namespace

* Updated docs with new parameter passing logic

* Automated dotnet-format update

* Updated changelog

Co-authored-by: Github Actions <[email protected]>
egil added a commit that referenced this issue Oct 2, 2020
@egil @actions-user
BunitHtmlFinder: parse context finder for markup strings that start w…
2611704 
…ith an html5 tag implemented (#220)

* reset changelog with unreleased section

* Cleanup using and resorted them

* Improvements to parameter passing in c# based tests (#203)

* componentparametercollection

* Support for passing multiple template and render fragments

* Automated dotnet-format update

* cascading values

* Finished component parameter collection, closed #142, updated tests to component parameter factory

* Fixed null warnings

* Automated dotnet-format update

* Fixes for CodeQL warnings

* Added ChildContent and RenderFragment tests

* Added support for passing template fragments

* Removed ComponentParameterBuilder, added support for unmatched and cascading values

* Switched to C# 9 compile

* Automated dotnet-format update

* unnamed cascading value with add

* Removed .net move hack from workflows

* Fix for null errors

* Automated dotnet-format update

* Added extra factory method and moved ComponentParameter out into Bunit namespace

* Updated docs with new parameter passing logic

* Automated dotnet-format update

* Updated changelog

Co-authored-by: Github Actions <[email protected]>

* Updated version to beta-11

* Context finder for strings that start with an html5 tag

* Fix for build error

* Added support for HTML, HEAD, and BODY, stopped reusing element contexts

* Cleanup usings

Co-authored-by: Github Actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Improvements to parameter passing bUnit-dev/bUnit
1 participant
@egil