fix: use safe-timers only large than interval && add tests #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atian25, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse and @fengmk2 to be potential reviewers. |
4 tasks
dead-horse
reviewed
Jun 5, 2017
agent.js
Outdated
| @@ -106,15 +105,15 @@ function startCron(interval, listener) { | |||
| } | |||
|
|
|||
| function safeTimeout(fn, delay, ...args) { | |||
| if (delay >= MAX_SAFE_TIME) { | |||
| if (delay >= safetimers.maxInterval) { | |||
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
========================================
+ Coverage 98.21% 100% +1.78%
========================================
Files 3 3
Lines 112 111 -1
========================================
+ Hits 110 111 +1
+ Misses 2 0 -2
Continue to review full report at Codecov.
|
atian25
changed the title
atian25
force-pushed
the
exports
branch
8 times, most recently
from
5b8e487 to
5b27e8e
Compare
|
@dead-horse 再看看，测试过了 |
dead-horse
approved these changes
Jun 6, 2017
|
2.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change