Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: async/await Example #12

Merged
merged 5 commits into from
Feb 15, 2017
Merged

feat: async/await Example #12

merged 5 commits into from
Feb 15, 2017

Conversation

popomore
Copy link
Member

@popomore popomore commented Feb 7, 2017

Closes eggjs/egg#276

fengmk2
fengmk2 reviewed Feb 8, 2017
View reviewed changes
hackernews-async/appveyor.yml Outdated
@@ -0,0 +1,14 @@
environment:
matrix:
- nodejs_version: '4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 7

fengmk2
fengmk2 reviewed Feb 8, 2017
View reviewed changes
hackernews-async/package.json Outdated
"supertest": "^3.0.0"
},
"engines": {
"node": ">=7.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.6.0

@dead-horse
Copy link
Member

这个我接手继续改

@dead-horse dead-horse mentioned this pull request Feb 10, 2017
Merged
2 tasks
@popomore
Copy link
Member Author

@dead-horse 这个也改好了？

@dead-horse
Copy link
Member

还没，power-assert 的转义有问题，要再看一下

@dead-horse
Copy link
Member

power-assert-js/espower-source#13

@twada
Copy link

twada commented Feb 13, 2017

FYI: Just released espower-source 2.0.1 for the bugfix. Thanks @dead-horse for your pull-req!

@dead-horse dead-horse changed the title WIP: feat: async/await Example feat: async/await Example Feb 13, 2017
@dead-horse
Copy link
Member

可以了，等 eggjs/bin#33 合并可以手动开启 harmony-async-await 来跑了。

node --harmony-async-await node_modules/.bin/egg-bin dev
node --harmony-async-await node_modules/.bin/egg-bin test

@popomore
Copy link
Member Author

我不能 approved 自己

@popomore
Copy link
Member Author

@dead-horse 参数还没加？

@dead-horse
Copy link
Member

参数不加了吧，我看看 README 里面写一下，应该可以通过 npm run dev -- --harmony-async-await 跑

@dead-horse
Copy link
Member

readme 更新了一下

@dead-horse dead-horse merged commit c59eef1 into master Feb 15, 2017
@dead-horse dead-horse deleted the async-await branch February 15, 2017 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@popomore @dead-horse @twada @fengmk2