chore: Release the first stable version 🥚 👏👏👏 #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@popomore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @atian25, @fengmk2 and @dead-horse to be potential reviewers. |
|
👏👏👏 |
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 26 26
Lines 633 633
=====================================
Hits 633 633Continue to review full report at Codecov.
|
|
@popomore Please merge and release! |
|
覆盖率降低和 egg-bin 有关系？ |
|
@popomore 换回去 2.x 跑跑看? |
|
|
|
有可能是这个原因， https://github.com/eggjs/egg-bin/blob/master/lib/cmd/cov.js#L59 上面复制了，下面才赋值，我发个 PR 修复下 |
popomore
force-pushed
the
release-proposal-1.0.0
branch
from
991eab3 to
1345abf
Compare
|
win 又卡在了 -.- |
|
覆盖率好像解决了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Closes #5