feat: support performance timer for more precise milliseconds #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g.: 1.375ms better than 1ms
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 97.36% 97.39% +0.02%
==========================================
Files 14 14
Lines 456 461 +5
Branches 72 73 +1
==========================================
+ Hits 444 449 +5
Misses 12 12
Continue to review full report at Codecov.
|
fengmk2
added a commit
to eggjs/egg
that referenced
this pull request
Nov 20, 2021
detail see eggjs/egg-logger#74 How to use: ```js // config.js exports.logger = { enablePerformanceTimer: true, }; ```
4 tasks
fengmk2
commented
Nov 20, 2021
| // Starting... | ||
| // 10 tests completed. | ||
|
|
||
| // logger.error(err) x 378,794 ops/sec ±1.35% (91 runs sampled) |
fengmk2
added a commit
to fengmk2/leoric
that referenced
this pull request
Nov 20, 2021
detail see eggjs/egg-logger#74 before: ```log [query] [1] DROP TABLE IF EXISTS `clients` ``` after: ```log [query] [1.478] DROP TABLE IF EXISTS `clients` ```
cyjake
pushed a commit
to cyjake/leoric
that referenced
this pull request
Nov 20, 2021
detail see eggjs/egg-logger#74 before: ```log [query] [1] DROP TABLE IF EXISTS `clients` ``` after: ```log [query] [1.478] DROP TABLE IF EXISTS `clients` ```
fengmk2
added a commit
to fengmk2/leoric
that referenced
this pull request
Nov 22, 2021
detail see eggjs/egg-logger#74 before: ```log [query] [1] DROP TABLE IF EXISTS `clients` ``` after: ```log [query] [1.478] DROP TABLE IF EXISTS `clients` ```
cyjake
pushed a commit
to cyjake/leoric
that referenced
this pull request
Nov 22, 2021
detail see eggjs/egg-logger#74 before: ```log [query] [1] DROP TABLE IF EXISTS `clients` ``` after: ```log [query] [1.478] DROP TABLE IF EXISTS `clients` ```
popomore
reviewed
Dec 5, 2021
test/lib/egg/context_logger.test.js
Outdated
| const m = body.match(/\/\d*ms/g); | ||
| (parseInt(m[1].substring(1)) > parseInt(m[0].substring(1))).should.equal(true); | ||
| const m = body.match(/\/\d+ms/g); | ||
| console.log(m); |
atian25
approved these changes
Dec 5, 2021
|
2.7.0 |
fengmk2
added a commit
to eggjs/egg
that referenced
this pull request
Dec 5, 2021
detail see eggjs/egg-logger#74 How to use: ```js // config.js exports.logger = { enablePerformanceTimer: true, }; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.: 1.375ms better than 1ms
Checklist
npm testpassesAffected core subsystem(s)
Description of change