Fix protocol check for wget availability #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Thanks for the catch! Sloppy implementation on my side 🙈 |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2022
## [2.2.3](v2.2.2...v2.2.3) (2022-03-05) ### Bug Fixes * **http:** corrects protocol check for wget availability ([#82](#82)) ([570c9fb](570c9fb))
github-actions bot
pushed a commit
to Penbase/wait-for
that referenced
this pull request
Mar 11, 2022
# 1.0.0 (2022-03-11) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [#16](#16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/Penbase/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/Penbase/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/Penbase/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [#14](#14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.
github-actions bot
pushed a commit
to gesellix/wait-for
that referenced
this pull request
Dec 21, 2022
# 1.0.0 (2022-12-21) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/gesellix/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/gesellix/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/gesellix/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/gesellix/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/gesellix/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.
github-actions bot
pushed a commit
to gesellix/wait-for
that referenced
this pull request
Dec 21, 2022
# 1.0.0 (2022-12-21) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/gesellix/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/gesellix/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/gesellix/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/gesellix/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/gesellix/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([4b9b12e](4b9b12e)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.
github-actions bot
pushed a commit
to gesellix/wait-for
that referenced
this pull request
Dec 21, 2022
# 1.0.0 (2022-12-21) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/gesellix/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/gesellix/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/gesellix/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/gesellix/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/gesellix/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([4b9b12e](4b9b12e)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.
github-actions bot
pushed a commit
to gesellix/wait-for
that referenced
this pull request
Dec 21, 2022
# 1.0.0 (2022-12-21) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/gesellix/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/gesellix/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/gesellix/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/gesellix/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/gesellix/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.
github-actions bot
pushed a commit
to gesellix/wait-for
that referenced
this pull request
Jan 8, 2023
# 1.0.0 (2023-01-08) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/gesellix/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/gesellix/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/gesellix/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/gesellix/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/gesellix/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.
github-actions bot
pushed a commit
to danieleagle/wait-for
that referenced
this pull request
Jun 2, 2023
# 1.0.0 (2023-06-02) ### Bug Fixes * `wget` in alpine runs into an endless retry loop ([eficode#100](https://github.com/danieleagle/wait-for/issues/100)) ([b15c461](b15c461)) * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/danieleagle/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/danieleagle/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/danieleagle/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/danieleagle/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/danieleagle/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.
github-actions bot
pushed a commit
to fitz7/wait-for
that referenced
this pull request
Dec 9, 2023
# 1.0.0 (2023-12-09) ### Bug Fixes * `wget` in alpine runs into an endless retry loop ([eficode#100](https://github.com/fitz7/wait-for/issues/100)) ([b15c461](b15c461)) * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/fitz7/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/fitz7/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/fitz7/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/fitz7/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/fitz7/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$PROTOCOLwill either betcp(the default) orhttp(set when$HOSTstarts with http or https).Previously the value
wgetwas being checked against, but it should behttpas that's the valuePROTOCOLwill be whenwgetis necessary.