Remove empty dirs #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries in Zip.scala, mirroring the behavior of StandaloneJarProcessor.java - Reimplemented copyZipWithoutEmptyDirectories to remove nested empty directories, and added a test for it. - Update SHA of shading tests of bytebuddy. A before and after diff of unzip -l shows no change in any file paths, timestamps and sizes, except for the two empty directories that get removed as expected: 7a8,9 > 0 01-03-1980 00:00 net/ > 0 01-03-1980 00:00 net/bytebuddy/ 93c95 < 733298 88 files --- > 733298 90 files
…kes SHAs for shading tests consistent across JDK versions 8, 11 and 21.
eed3si9n
reviewed
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
bytebuddy. A before and after diff ofunzip -lshows no change in any file paths, timestamps and sizes, except for the two empty directories that get removed as expected: