better placeholder

eebbesen · Dec 18, 2024 · 7653a2f · 7653a2f
1 parent d2a47ca
commit 7653a2f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 19 deletions.
diff --git a/StpFoodBlazor/StpFoodBlazor/Components/Layout/DealTableBodyPlaceholder.razor b/StpFoodBlazor/StpFoodBlazor/Components/Layout/DealTableBodyPlaceholder.razor
@@ -1,24 +1,13 @@
 @inherits LayoutComponentBase
 @using StpFoodBlazor.Models
 
-<span id="deals_table_body_placeholder" class="placeholder-glow" aria-hidden="true">
+<span id="deals_table_body_placeholder" aria-hidden="true">
     @{var rowCounter = 0;}
     @foreach (var deal in Enumerable.Range(1, 30))
     {
-        <div class="row rounded@(rowCounter % 2 == 0 ? " bg-secondary opacity-25" : "")">
-            @if (string.IsNullOrEmpty(selectedDayOfWeek))
-            {
-                <span class="col-1 placeholder"></span>
-            }
-            <span class="col-3 placeholder"></span>
-            <span class="col placeholder"></span>
+        <div class="row rounded placeholder-glow">
+            <span class="col-12 rounded placeholder@(rowCounter % 2 == 0 ? " bg-white" : "")"></span>
         </div>
         rowCounter++;
     }
 </span>
-
-@code
-{
-    [Parameter]
-    public string selectedDayOfWeek { get; set; }
-}
diff --git a/StpFoodBlazor/StpFoodBlazor/Components/Pages/Deals.razor b/StpFoodBlazor/StpFoodBlazor/Components/Pages/Deals.razor
@@ -14,11 +14,10 @@
     <div class="container mb-5">
         <DealFilterBar selectedDayOfWeek="@selectedDayOfWeek" OnSelectedDayChanged="OnSelectedDayChanged"
             happyHour="@happyHour" OnHappyHourChanged="OnHappyHourChanged" />
-
         <DealTableHeader selectedDayOfWeek="@selectedDayOfWeek" />
 @if (deals == null)
 {
-        <DealTableBodyPlaceholder selectedDayOfWeek="@selectedDayOfWeek" />
+        <DealTableBodyPlaceholder />
 }
 else
 {

diff --git a/StpFoodBlazor/StpFoodBlazorTest/Pages/DealsTest.razor b/StpFoodBlazor/StpFoodBlazorTest/Pages/DealsTest.razor
@@ -31,9 +31,7 @@
         var elements = cut.Find("#deals_table_body_placeholder");
 
         Assert.Equal(30, elements.ChildElementCount);
-        Assert.Equal("<span class=\"col-1 placeholder\"></span>" +
-            "<span class=\"col-3 placeholder\"></span>\n            " +
-            "<span class=\"col placeholder\"></span>",
+        Assert.Equal("<span class=\"col-12 rounded placeholder bg-white\"></span>",
             elements.Children[0].InnerHtml);
     }