fix: allow verified name to be created if user is trying to verify with the same name #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
commented
May 17, 2022
edx_name_affirmation/tasks.py
Outdated
| @@ -37,7 +38,7 @@ def idv_update_verified_name_task(self, attempt_id, user_id, name_affirmation_st | |||
| 'status': name_affirmation_status | |||
| } | |||
| ) | |||
| verified_names = VerifiedName.objects.filter(user__id=user_id, verified_name=photo_id_name).order_by('-created') | |||
| verified_names = VerifiedName.objects.filter((Q(verification_attempt_id = attempt_id) | Q(verification_attempt_id__isnull = True)) & Q(user__id = user_id) & Q(verified_name = photo_id_name)).order_by('-created') | |||
There was a problem hiding this comment.
We don't want to try and update all verified name objects that match the user id and verified name, only the ones that either a) are not associated with any IDV attempt yet or b) are associated with the IDV attempt we got an update for.
alangsto
force-pushed
the
alangsto/fix_status_update
branch
3 times, most recently
from
12274fc to
85cd53e
Compare
schenedx
reviewed
May 18, 2022
| @@ -37,7 +38,11 @@ def idv_update_verified_name_task(self, attempt_id, user_id, name_affirmation_st | |||
| 'status': name_affirmation_status | |||
| } | |||
| ) | |||
| verified_names = VerifiedName.objects.filter(user__id=user_id, verified_name=photo_id_name).order_by('-created') | |||
| verified_names = VerifiedName.objects.filter( | |||
There was a problem hiding this comment.
#NIT add a comment here to explain that when multiple VerifiedName records exists, there might be records we want to update that is not the latest created.
schenedx
approved these changes
May 18, 2022
alangsto
force-pushed
the
alangsto/fix_status_update
branch
from
85cd53e to
1ce8c9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently if a user tries to submit an IDV attempt with the same name as a previous IDV attempt that was reviewed, no verified name record will be created for them.
Splunk logs will show that in this case, it looks like a verified name is actually created for the learner, even though no record is actually created.
JIRA:
MST-1514
Pre-Merge Checklist:
edx_name_affirmation/__init__.pyif these changes are to be released. See OEP-47: Semantic Versioning.CHANGELOG.rst.Post-Merge: