Post django32 cleanup #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aht007
force-pushed
the
aht/BOM-3185-POST-DJANGO32-CLEANUP
branch
4 times, most recently
from
3fe09dc to
64ef478
Compare
UsamaSadiq
approved these changes
Feb 15, 2022
.github/workflows/ci.yml
Outdated
| - quality | ||
| - pii_check | ||
| - rst_validation | ||
| - django32 |
There was a problem hiding this comment.
This should also be in a list format.
tox.ini
Outdated
| django30: Django>=3.0,<3.1 | ||
| deps = | ||
| django32: Django>=3.2,<4.0 | ||
| django40: Django>=4.0,<4.1 | ||
| -r{toxinidir}/requirements/test.txt | ||
| celery44: celery>=4.0,<5.0 |
There was a problem hiding this comment.
We should also create a requirement file for celery44 similar to celery50.
|
Please share with ARCH-bom or SRE team to remove the required Django version and mark the |
aht007
force-pushed
the
aht/BOM-3185-POST-DJANGO32-CLEANUP
branch
from
64ef478 to
ce7eef9
Compare
UsamaSadiq
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Post Django32 cleanup
JIRA:
BOM-3185
Pre-Merge Checklist:
edx_name_affirmation/__init__.pyif these changes are to be released. See OEP-47: Semantic Versioning.CHANGELOG.rst.Post-Merge: