Fix permissions issues for python-coverage-comment action step #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user without the proper permissions on the repository authors a commit, the python-coverage-comment step in the CI action fails because the user does not have permissions to post comments to the pull request. In order to fix this, split the coverage step into two. 1. In ci.yml, checkout the repository and generate and save the coverage comment that should be posted. 2. In coverage.yml, publish the saved coverage comment to the pull request. For security reasons, we do not want to give permissions to the ci.yml action, because it checks out untrusted code. Coverage.yml is a trusted workflow that can post the saved coverage comment from the untrusted workflow.
Coverage report
This PR does not seem to contain any modification to coverable code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When a user without the proper permissions on the repository authors a commit, the
python-coverage-commentstep in the CI action fails because the user does not have permissions to post comments to the pull request.In order to fix this, split the coverage step into two.
JIRA:
None.
Pre-Merge Checklist:
edx_name_affirmation/__init__.pyif these changes are to be released. See OEP-47: Semantic Versioning.CHANGELOG.rst.Post-Merge: