chore: Elm theme improvement on course home #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedbashir
changed the title
rnr
approved these changes
Oct 9, 2024
Theme/Theme/Theme.swift
Outdated
| @@ -76,6 +76,7 @@ public struct Theme { | |||
| public private(set) static var courseCardShadow = ThemeAssets.courseCardShadow.swiftUIColor | |||
| public private(set) static var courseCardBackground = ThemeAssets.courseCardBackground.swiftUIColor | |||
| public private(set) static var deleteAccountBG = ThemeAssets.deleteAccountBG.swiftUIColor | |||
| public private(set) static var courseProgressGB = ThemeAssets.courseProgressGB.swiftUIColor | |||
There was a problem hiding this comment.
misspelling 'GB' instead 'BG'?
shafqat-muneer
approved these changes
Oct 11, 2024
| @@ -126,8 +127,9 @@ struct CustomDisclosureGroup: View { | |||
| VStack(alignment: .leading) { | |||
| HStack { | |||
| if sequential.completion == 1 { | |||
| CoreAssets.finishedSequence.swiftUIImage | |||
| CoreAssets.finishedSequence.swiftUIImage.renderingMode(.template) | |||
There was a problem hiding this comment.
Is there a way to prevent this warning while following the specified guidelines?
Line Length Violation: Line should be 120 characters or less; currently it has 125 characters
There was a problem hiding this comment.
Unfortunately, didn't get a way to break it into multiple lines.
rnr
pushed a commit
that referenced
this pull request
Dec 17, 2024
rnr
added a commit
that referenced
this pull request
Dec 19, 2024
* chore: added alpha for color to whitelabel (#87) Co-authored-by: Anton Yarmolenko <[email protected]> * chore: Elm theme improvements on Learn Tab (#88) * chore: Elm theme improvement on course home (#86) * chore: fix line length warning * chore: Elm theme improvement on Course Discussions (#90) * fix: fix after merge * chore: Elm theme improvements for modals and alerts (#91) * chore: fix after merge * chore: configureable resume button (#92) --------- Co-authored-by: Anton Yarmolenko <[email protected]> Co-authored-by: Saeed Bashir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira Ticket: LEARNER-10146
Update the progress bar background color, checkmark color, and download icon color as suggested by the design team.
Config PR: https://github.com/edx/edx-mobile-config/pull/181