Fix social auth banner after whats new screen #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forgotvas
approved these changes
Dec 23, 2024
rnr
added a commit
that referenced
this pull request
Jan 9, 2025
* chore: transfer post login data through WhatNew screen * chore: fixes after merge * chore: refactor after merge * chore: fixed tests and regenerate mocks * chore: added default post login data * chore: little refactor --------- Co-authored-by: Anton Yarmolenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, when Whats New View is enabled, when Whats New View is displayed on first startup, the application does not show the social registered banner. This is because the notification that is sent after a successful login does not exist until the Main View is displayed.
Now we transfer the post-login data through the WhatNew Model to the MainView Model
Screen.Recording.2024-12-18.at.19.34.15.mov
Screen.Recording.2024-12-18.at.19.32.23.mov