feat!: remove code owner optional prefix paths #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a TODO comment stating that once edx-platform import_shims is no longer used, we could remove the _OPTIONAL_MODULE_PREFIX_PATTERN implementation. See https://github.com/openedx/edx-platform/tree/854502b560bda74ef898501bb2a95ce238cf794c/import_shims Phase 1 of the code owner refactor is an opportune time to make this clean-up because we can compare code_owner and code_owner_2 results. See #784
This will be released with another change, and it doesn't need a changelog entry.
UsamaSadiq
approved these changes
Dec 5, 2024
|
Thanks @UsamaSadiq. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a TODO comment stating that once
edx-platform import_shims is no longer used, we
could remove the _OPTIONAL_MODULE_PREFIX_PATTERN
implementation.
See https://github.com/openedx/edx-platform/tree/854502b560bda74ef898501bb2a95ce238cf794c/import_shims
Phase 1 of the code owner refactor is an opportune time to make this clean-up because we can compare code_owner and code_owner_2 results.
See #784
Merge checklist:
Check off if complete or not applicable: