Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for UNC paths for App URI #145

Merged
merged 9 commits into from
Dec 21, 2018
Merged

Adding Support for UNC paths for App URI #145

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
178d8dc
Clarified how to use the two magical strings for cacheDir. A full exp…
TurekBot Dec 19, 2018
372d667
Fixed one case of resolve, checking for a "/" and then adding on app.…
TurekBot Dec 19, 2018
cfa70b8
Fixed another case of resolve. Checking for "/" and acting accordingly.
TurekBot Dec 19, 2018
84d8a6e
Fixed one more case of URI.resolve. Checking for "/" and acting accor…
TurekBot Dec 19, 2018
d642678
Clarified the comment referring to the issue to make it clearer which
TurekBot Dec 19, 2018
2283f39
Written much cleaner per edvin's comments.
TurekBot Dec 20, 2018
38b7b00
Checking if appStr has a slash per edvin's comments.
TurekBot Dec 20, 2018
390e702
Now using the separator logic as was previously used.
TurekBot Dec 20, 2018
c1d0ae3
Added a bit about the UNC paths to the README.
TurekBot Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,16 +116,26 @@ Check out these prebuilt installers for a more complex demo application

## Specify cache directory

By default, the artifacts are downloaded to the current working directory. This is usually fine for native installers, but if you distribute
your application via just the launcher jar, you might want to specify where the downloaded artifacts land. See the
[cache dir documentation](https://github.com/edvin/fxlauncher/wiki/Optional-Cache-Directory) for more information.
By default, the artifacts are downloaded to the current working directory. This is usually fine for per-user native
TurekBot marked this conversation as resolved.
Show resolved Hide resolved
installers, but if you distribute your application via a system-wide native installer, or just the launcher
jar, you might want to specify where the downloaded artifacts land. See the
[cache dir documentation] for more information.

[cache dir documentation]: https://github.com/edvin/fxlauncher/wiki/Optional-Cache-Directory

## Installation location

It's worth noting that the two package alternatives for Windows, (EXE and MSI) have different install location defaults.
While EXE will default to %APPDATALOCAL%, the MSI installer will default to %ProgramFiles%. If you use the MSI installer you
might therefore need to specify the cache dir parameter as `cacheDir 'USERLIB/MyApp'` to make sure that the launcher has
write access to download the artifacts for your application.
It's worth noting that the two package alternatives for Windows, (EXE and MSI) have different default install locations.
While EXE will default to [`%AppDataLocal%`], the MSI installer will default to `%ProgramFiles%`. To write to
`%ProgramFiles%` one definitely does need admin privileges—that poses a problem for FXLauncher which, by default,
downloads updates to where it was installed.

If you use the MSI installer you will therefore need to tell FXLauncher to cache artifacts somewhere it is allowed
to put them. For an OS-independent answer to this problem, look no further than the
[two magical strings][cache dir documentation], `USERLIB` and `ALLUSERS`.


[`%AppDataLocal%`]: https://www.howtogeek.com/318177/what-is-the-appdata-folder-in-windows/

Read more about Java Packager in the official documentation:

Expand Down