Adding UI parameters #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows you to customize the UI. The fields to customize the UI were already apart of FXLauncher, there was just no easy way to change them. The fields are * updateText (--update-text) * updateLabelStyle (--update-label-style) * progressBarStyle (--progress-bar-style) * wrapperStyle (--wrapper-style)
moved everything to where it belongs under the Optional parameters section and changed the headings accordingly
|
@edvin, this should expose the UI properties added in FXLauncher's #158 (edvin/fxlauncher#158), but in the plugin. |
|
Hi, @edvin. I'm sure you just missed this because you're busy with other things. If there's something I can do to make merging this easier for you, I'd be happy to do it. |
|
Hi @TurekBot - sorry about that, things are crazy at the moment :) It looks fine, I'll merge. Perhaps you would like to help out with maintaining/publishing this plugin? I don't use Gradle myself, you see. |
|
@edvin, I'm just a Gradle fledgling myself, but I'd love to help. |
|
@edvin, If it's something I can help with, I'd love to get a new release of the plugin published. |
|
Version 1.0.21.1 is now in maven central :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to PR #158 in edvin/fxlauncher (edvin/fxlauncher#158).
It allows you to customize the UI. The fields to customize the UI were
already apart of FXLauncher, there was just no easy way to change them.
The fields are