CopyAppDependenciesTask to copy just the changed dependencies #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its inputs and outputs. Here I've given the task properties and identified them with the appropriate annotations, as described in the documentation (https://docs.gradle.org/current/userguide/more_about_tasks.html#sec:up_to_date_checks)
* Using the IncrementalTaskInputs, as described in the documentation, to only do something about inputs that have changed. * I don't think I'm passing in the inputs in right, but they need to be passed in somewhere, right? * I realized that I'd made the properties private and like that no one can access them. Did I get them right this time?
TurekBot
commented
Dec 21, 2018
| File workingDirectory = project.extensions.fxlauncher.resolveWorkingDirectory() | ||
| if (!workingDirectory.exists()) workingDirectory.mkdirs() | ||
| project.configurations.runtime.resolvedConfiguration.resolvedArtifacts.each { artifact -> | ||
| void copyDependencies(IncrementalTaskInputs inputs) { |
There was a problem hiding this comment.
The IncrementalTaskInputs, is a way, according to the documentation, to check if each input has changed, and only deal with the changed ones.
TurekBot
commented
Dec 21, 2018
| @@ -54,7 +54,11 @@ class FXLauncherPlugin implements Plugin<Project> { | |||
| type: CopyAppDependenciesTask, | |||
| group: 'FXLauncher', | |||
| description: 'Copies all application runtime dependencies into working directory', | |||
| dependsOn: project.tasks.jar | |||
| dependsOn: project.tasks.jar, | |||
There was a problem hiding this comment.
@aalmiray, maybe you can leave one of those newfangled suggestions on how to do this the right way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, this isn't quite ready yet, but I'm going to start the pull request so it can be seen what I've got so far.
I've been following the suggestions of @aalmiray from Issue #23.