Skip to content

Commit

Permalink
Disabled tslint rule : mgechev/codelyzer#191 for false positive.
Browse files Browse the repository at this point in the history
Fixed tslint errors.
  • Loading branch information
edud69 committed Aug 20, 2017
1 parent d95488d commit 0e6f868
Show file tree
Hide file tree
Showing 19 changed files with 28 additions and 30 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!-- template -->

Restoring password for : {{form.username}}
Confirmation token : {{form.lostPasswordToken}}
Restoring password for : {{ form.username }}
Confirmation token : {{ form.lostPasswordToken }}

<sd-error-box [error]="error"></sd-error-box>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export class FacebookSocialSigninButtonComponent {

getLink() : string {
let tid = this._tenantResolverService.resolveCurrentTenant();
return this._signinService.socialProviderLinks.facebook + '?tenant=' + tid;
return this._signinService.socialProviderLinks.facebook + '?tenant=' + tid;
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ export class GoogleSocialSigninButtonComponent {

getLink() : string {
let tid = this._tenantResolverService.resolveCurrentTenant();
return this._signinService.socialProviderLinks.google + '?tenant=' + tid;
return this._signinService.socialProviderLinks.google + '?tenant=' + tid;
}
}
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Activation in process...

Account confirmed : {{accountConfirmed}}
Account confirmed : {{ accountConfirmed }}
6 changes: 3 additions & 3 deletions src/client/app/home/components/home.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ <h1>Test JIG</h1>

<md-card>
<md-card-title>Websocket test (will become eventually a directive for chat / one for push notifications</md-card-title>
<md-card-subtitle>CHAT-WEBSOCKET status: {{status}}</md-card-subtitle>
<md-card-subtitle>CHAT-WEBSOCKET status: {{ status }}</md-card-subtitle>
<md-card-content>
<form (submit)="sendChat()" *ngIf="status == 'ONLINE'">
<input [(ngModel)]="chatMessage" [ngModelOptions]="{standalone: true}" placeholder="Enter your message!" (keypress)="enableTypingAction()">
Expand All @@ -29,7 +29,7 @@ <h1>Test JIG</h1>
</div>

<md-list dense style="margin-top: 10px;">
<md-list-item *ngFor="let chatmsgs of displayChatMessages()"><div>{{chatmsgs}}</div></md-list-item>
<md-list-item *ngFor="let chatmsgs of displayChatMessages()"><div>{{ chatmsgs }}</div></md-list-item>
</md-list>
</md-card-content>
</md-card>
Expand All @@ -39,7 +39,7 @@ <h1>Test JIG</h1>
<md-card-title>Forms components</md-card-title>
<md-card-content>
<b>Image upload</b>
<div>Url: {{docBackendApi}}</div>
<div>Url: {{ docBackendApi }}</div>
<div style="margin-top: 10px;">
<div><b>Single file upload:</b></div>
<sd-file-upload [uploadUrl]="docBackendApi" uploaderType="singlefile" maxSizeKb="500" fileTypes="*" [subscriber]="fileuploadSub"></sd-file-upload>
Expand Down
2 changes: 1 addition & 1 deletion src/client/app/profile/components/profile.component.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component} from '@angular/core';
import { Component } from '@angular/core';

import { ManagedComponent, IFileUploadResultsSubscriber, LoggerService } from '../../shared/index';

Expand Down
5 changes: 3 additions & 2 deletions src/client/app/profile/services/profile.service.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Injectable} from '@angular/core';
import { Injectable } from '@angular/core';

import { IApiResult, HttpRestService, AuthTokenService, EventService, ProfileLiteRefreshEvent, HttpUrlUtils } from '../../shared/index';

Expand Down Expand Up @@ -28,7 +28,8 @@ export class ProfileService {
updateProfile(form : ProfileForm) : IApiResult<Profile> {
let userId = this._authTokenService.currentUserId();
let payload = new Profile(userId, form.firstName, form.lastName, form.gender, form.birthday, form.avatarUrl);
let apiResult = this._httpRestService.httpPut<Profile>(HttpUrlUtils.combineId('<%= BACKEND_API.ACCOUNTSERVICE_API_updateProfile %>', payload.userId), payload);
let apiResult = this._httpRestService.httpPut<Profile>(
HttpUrlUtils.combineId('<%= BACKEND_API.ACCOUNTSERVICE_API_updateProfile %>', payload.userId), payload);
this._addProfileUpdatedInterceptor(apiResult);
return apiResult;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div *ngIf="errorMessage" style="display: inline-block; margin-top: 20px;" align="center">
<md-card>
<span style="color:red;"><md-icon>error</md-icon>{{errorMessage}}</span>
<span style="color:red;"><md-icon>error</md-icon>{{ errorMessage }}</span>
</md-card>
</div>
2 changes: 0 additions & 2 deletions src/client/app/shared/components/error/error-box.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ export class ErrorBoxComponent {

errorMessage : string;

constructor() {}

@Input()
set error(apiError: ApiError) {
if (apiError) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Component, Injectable, Input } from '@angular/core';
import {CompleterItem } from 'ng2-completer';
import { CompleterItem } from 'ng2-completer';

import { AutoCompleteDataProviderService } from '../../../services/forms/auto-complete/auto-complete-data-provider.service';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@

<!-- Errors -->
<div *ngFor="let error of errorMessages">
<span *ngIf="error" style="color:red;">{{error}}</span>
<span *ngIf="error" style="color:red;">{{ error }}</span>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ export class FormFieldErrorLabelComponent implements OnDestroy {

private _sub : any;

constructor() {}

@Input()
set form(baseForm: BaseForm) {
this.baseForm = baseForm;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {Component, Injectable, Input} from '@angular/core';
import { Component, Injectable, Input } from '@angular/core';

import {ManagedComponent} from '../../index';
import { ManagedComponent } from '../../index';


@Component({
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import {Subject} from 'rxjs/Subject';
import {Injectable} from '@angular/core';
import {Headers} from '@angular/http';
import {CompleterData, CompleterItem} from 'ng2-completer';
import { Subject } from 'rxjs/Subject';
import { Injectable } from '@angular/core';
import { Headers } from '@angular/http';
import { CompleterData, CompleterItem } from 'ng2-completer';

import {BaseModel, ApiError, LoggerService, HttpRestService, HttpConstants, SearchResults} from '../../../index';
import { BaseModel, ApiError, LoggerService, HttpRestService, HttpConstants, SearchResults } from '../../../index';

@Injectable()
export class AutoCompleteDataProviderService extends Subject<CompleterItem[]> implements CompleterData {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export function main() {
loggerService.info(message, [':-)', [1,2,3,'YO']]);
expect(console.info).toHaveBeenCalled();
let logStr = <string>(spy.calls.mostRecent().args[0]);
let logged = logStr.substring(logStr.indexOf('INFO -') + 7, logStr.length)
let logged = logStr.substring(logStr.indexOf('INFO -') + 7, logStr.length);
expect(logged).toBe(expected);
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function main() {
beforeEach(() => {
// weird bug that displays a Karma warning for missing css. It should not happen as this is a service, not component
// maybe the service is loading a component (when it should not)
document.body.insertAdjacentHTML('afterbegin', '<link rel=\"stylesheet\" href=\"/base/dist/dev/css/indigo-pink.css\" />')
document.body.insertAdjacentHTML('afterbegin', '<link rel=\"stylesheet\" href=\"/base/dist/dev/css/indigo-pink.css\" />');

mockedAuthTokenService = new MockedAuthTokenService(null, mockedLoggerService);
serviceUnderTest = new WebsocketService(mockedLoggerService, mockedAuthTokenService);
Expand Down
2 changes: 1 addition & 1 deletion src/client/app/shared/toolbar/toolbar.component.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div *ngIf="isAuthenticated">
<md-icon>lock</md-icon>
Welcome: {{profileLite?.firstName + ' ' + profileLite?.lastName}}
Welcome: {{ profileLite?.firstName + ' ' + profileLite?.lastName }}

<img [src]="profileLite?.avatarUrl" height="25" width="25"/>

Expand Down
2 changes: 1 addition & 1 deletion src/client/testing/models/base-model-test-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export namespace BaseModelTestUtils {
result.message = `Expected ${input.bindingClassName} to be ` +
`registered as ${input.targetClass}, but it was not`;
}

return result;
}
})
Expand Down
1 change: 1 addition & 0 deletions tslint.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"extends": "./tools/config/seed.tslint.json",
"rules": {
"no-access-missing-member": false
}
}

0 comments on commit 0e6f868

Please sign in to comment.