AMP headers #148
Merged
AMP headers #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the __amp_source_origin query string is found in a submission's request, then add AMP-specific HTTP headers to the response from Staticman. That way the query will be successful on the AMP page, it would abort for security reasons otherwise.
|
@eduardoboucas sorry to bother you as I imagine you're short on time, but did you get a chance to look at this? |
|
Hey @maxime-michel, sorry for the delayed response. I've had a first look through the PR and it looks good! I have pushed to After that, I think we're ready to merge this to Thanks for your effort, it's top notch! |
|
Actually, tests are passing now. Merging! |
caiopavanelli
pushed a commit
to caiopavanelli/staticman
that referenced
this pull request
Aug 17, 2020
Added Bitbucket social button to social.toml and the exampleSite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #143. I tried to add a config toggle initially, but couldn't make that idea to work. But I actually like it better this way, it's automagic.
I haven't been able to actually test it yet: although I follow the instructions regarding the GitHub token & the SSH key, I end up with the following error:
Error: Key format must be specified