build: remove boto3 from requirements #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mariajgrimaldi, should we remove the libraries from the |
|
@BryanttV: of course! I'll do it right away |
Ian2012
reviewed
Oct 10, 2023
| # via | ||
| # -r requirements/quality.txt | ||
| # pylint | ||
| # pylint-celery | ||
| bleach==6.0.0 | ||
| boto3==1.28.62 |
There was a problem hiding this comment.
There is still a boto3 requirement, but it's an older version. Is it working?
There was a problem hiding this comment.
I think that lib is being used by the xblock library but not by us directly. Either way, since it's not in the base.in when installing the library it won't have any effect because it's not a requirement anymore
Ian2012
approved these changes
Oct 10, 2023
BryanttV
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes boto from requirements since it's no longer in use.