Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to see multiple xblock mindmap in lms #29

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

johnvente
Copy link
Contributor

@johnvente johnvente commented Oct 2, 2023

Description
When we create more than one XBlock per unit in the LMS, it breaks due to a draggable plugin from jsmind that was initialized previously, which is weird because each XBlock in the LMS is an iframe. This fix allows us to create any number of XBlocks without that issue

BEFORE NOW

How to test

  1. Once you have the XBlock in your environment, go to Studio > create a unit > create some XBlock-type mind maps.
  2. Publish the changes.
  3. Go to the LMS to see the unit.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets
  • Changelog record added

Copy link
Contributor

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error was fixed! Thanks

@BryanttV
Copy link
Contributor

BryanttV commented Oct 2, 2023

@johnvente, when I add more than one block to the unit it does not allow me to display the instructions for use, it closes by itself.

@johnvente
Copy link
Contributor Author

johnvente commented Oct 2, 2023

@johnvente, when I add more than one block to the unit it does not allow me to display the instructions for use, it closes by itself.

@BryanttV Nice catch! I've done the fix for that

@BryanttV
Copy link
Contributor

BryanttV commented Oct 2, 2023

@johnvente, good! It no longer closes by itself, however, when I open/close one block's instructions, the other blocks do the same.

@johnvente
Copy link
Contributor Author

@johnvente, good! It no longer closes by itself, however, when I open/close one block's instructions, the other blocks do the same.

@BryanttV too odd, fixed it! 🚀

@BryanttV
Copy link
Contributor

BryanttV commented Oct 2, 2023

Perfect! 💯 , LGTM

@johnvente johnvente merged commit ba978b5 into main Oct 2, 2023
@johnvente johnvente deleted the jv/fix-multiple-xblock-lms-jsmind branch October 2, 2023 18:09
@johnvente johnvente restored the jv/fix-multiple-xblock-lms-jsmind branch October 3, 2023 19:04
@mariajgrimaldi mariajgrimaldi deleted the jv/fix-multiple-xblock-lms-jsmind branch November 24, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants