Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consider weight in score calculation #28

Merged
merged 15 commits into from
Oct 6, 2023
Merged

Conversation

mariajgrimaldi
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi commented Sep 29, 2023

Description

This PR changes what is considered the final score for the student. Before these changes, we considered the raw score as the final score for the student without considering the weight configured. Now, we calculate the final score based on the weight configured in studio. This change has a downside: after calculating the new score, we could get numbers like 5.3 which cannot be saved in the submissions API so we decided to round to the nearest integer.

How to test

  1. Configure grading in your course as follows:
    image
  2. Install this branch and add the xblock to your course
  3. Configure your mindmap with your preferred weight. For this test, we're using 10 (the default):
    image
  4. As a student, submit a mindmap
    image
  5. As course staff, go to the component in the LMS and grade the submission:
    image
  6. As a student, check out your grade:
    image
    From the progress page:
    image
    Since the problem weight is 100, then our grade is 50. If the problem weight is 50, then our grade would be 25% and so on. Now, the subsection grade is our weighted score.

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/consider-weight branch 4 times, most recently from 1dd885c to 3a96308 Compare October 4, 2023 19:28
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review October 4, 2023 20:50
@mariajgrimaldi mariajgrimaldi requested a review from a team October 4, 2023 20:51
@BryanttV
Copy link
Contributor

BryanttV commented Oct 5, 2023

@mariajgrimaldi, it works fine except for one test case. I configured a component like this:

  • weight=10 (default)
  • maximum_score=100 (default)

As an instructor, I scored the submission with 5, but the submissions list doesn't show me the Raw score, should show me 5/100
image

@BryanttV
Copy link
Contributor

BryanttV commented Oct 6, 2023

LGTM!

@mariajgrimaldi
Copy link
Contributor Author

I'll be merging this since all comments have been addressed!

@mariajgrimaldi mariajgrimaldi merged commit 82cb438 into main Oct 6, 2023
5 checks passed
@mariajgrimaldi mariajgrimaldi deleted the MJG/consider-weight branch October 6, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants