-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: consider weight in score calculation #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariajgrimaldi
force-pushed
the
MJG/consider-weight
branch
4 times, most recently
from
October 4, 2023 19:28
1dd885c
to
3a96308
Compare
Ian2012
reviewed
Oct 5, 2023
johnvente
reviewed
Oct 5, 2023
@mariajgrimaldi, it works fine except for one test case. I configured a component like this:
As an instructor, I scored the submission with |
mariajgrimaldi
force-pushed
the
MJG/consider-weight
branch
from
October 5, 2023 16:49
7cc32ea
to
d1b21bd
Compare
LGTM! |
BryanttV
approved these changes
Oct 6, 2023
I'll be merging this since all comments have been addressed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes what is considered the final score for the student. Before these changes, we considered the
raw score
as the final score for the student without considering the weight configured. Now, we calculate the final score based on the weight configured in studio. This change has a downside: after calculating the new score, we could get numbers like 5.3 which cannot be saved in the submissions API so we decided to round to the nearest integer.How to test
From the progress page:
Since the problem weight is 100, then our grade is 50. If the problem weight is 50, then our grade would be 25% and so on. Now, the subsection grade is our weighted score.