feat: show assignment information to students v2 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian2012
reviewed
Sep 21, 2023
| @@ -234,6 +259,7 @@ def student_view(self, _context=None) -> Fragment: | |||
| Returns: | |||
| Fragment: The fragment to render | |||
| """ | |||
| self.set_submission_status() | |||
There was a problem hiding this comment.
Reformat this function call to a get_submission_status
Ian2012
reviewed
Sep 21, 2023
| } | ||
| student_item_dict = self.get_student_item_dict() | ||
| create_submission(student_item_dict, answer) | ||
|
|
||
| self.submitted = True | ||
| self.submission_status = SubmissionStatus.SUBMITTED.value |
|
Closing this since it's not going to be pursued |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to implement the same functionality of this PR but using the submission API
Limitations
Using the submissions API a submission must be created for each status change in the assignment. The problem is in the state changes from:
enter_grade)remove_grade)As these changes are made by the instructor it would not be possible to access the
self.mindmap_student_bodyfield, which does not allow to create the new submission.