Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability to configure the block as scorable from Studio #21

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Sep 19, 2023

Description

This PR adds the ability to configure the component of the XBlock as scorable from Studio.

How To Test

  1. Install this branch in your environment.
  2. Add a block in a unit from Studio.
  3. As an instructor, you should be able to select the component as scorable or no-scorable from the component settings in Studio.
  4. As a student only the save button should be available.

Screenshots

Studio

image

LMS

image

Limitations

The current implementation was based on H5P XBlock, however, it has a limitation with the following use case:

  1. As an instructor I define a component as scorable=True
  2. As a student I make my submission.
  3. As an instructor I grade the student's submission.
  4. As a student I can see my progress in the course.
    image
  5. As an instructor I define the same component as scorable=False
  6. As a student, I no longer get the component score, but it still counts in the course progress.
    image

@BryanttV BryanttV force-pushed the bav/mind-map-is-scorable branch from 90c4b6b to 1d4c6ef Compare September 19, 2023 20:20
@BryanttV BryanttV marked this pull request as ready for review September 20, 2023 23:10
@BryanttV BryanttV requested review from Ian2012, mariajgrimaldi, johnvente and nandodev-net and removed request for Ian2012 and mariajgrimaldi September 20, 2023 23:43
@Ian2012
Copy link
Contributor

Ian2012 commented Sep 21, 2023

@BryanttV There is a command to recalculate the grades of a course, can you run that command and verify if the issue persists?

@BryanttV
Copy link
Contributor Author

@Ian2012, Could you confirm me which is that command?

"Whether the component is scorable. If is scorable, the student "
"can submit the mind map and receive a score from the instructor. "
"If it is not scorable, the student only can save the mind map. "
"Important: Changing from scorable to not scorable, the progress "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Important: Changing from scorable to not scorable, the progress "
"WARNING: Changing from scorable to not scorable, the progress "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@BryanttV BryanttV force-pushed the bav/mind-map-is-scorable branch from b97a9e9 to b357edc Compare September 21, 2023 19:40
@BryanttV BryanttV force-pushed the bav/mind-map-is-scorable branch from b357edc to 60d5033 Compare September 21, 2023 19:48
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working expected! Thanks

@BryanttV BryanttV merged commit becfb01 into main Sep 22, 2023
5 checks passed
@BryanttV BryanttV deleted the bav/mind-map-is-scorable branch September 22, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants