-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add patches to compile and enable themes #5
Conversation
1c47ef1
to
7d6f05e
Compare
7d6f05e
to
5f10a56
Compare
59b9905
to
f4dedbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my perspective, everything is fine.
I only think that the *-env
patches are using PICASSO_DEFAULT_SITE_THEME
so this property should be in the README too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be testing this throughout the day. Thanks!
Thanks for the feedback, @mariajgrimaldi @dcoa. I'd love a re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR adds the necessary patches to compile and enable the themes.
For adding the patches we read:
TUTOR_VERSION
,PICASSO_THEME_DIRS
andPICASSO_THEMES_NAME
, similar totutor-contrib-edunext-distro
.Context
With the command
enable-themes
, we are cloning our repository themes in/openedx/themes
, but the themes sometimes aren't in the root of that repository, and we need to specify the platform where to find our themes. So, we usePICASSO_THEME_DIRS
. We also need to compile the themes and enable the comprehensive themes.How to test it
This code is used in this job: https://picasso.dedalo.edunext.co/job/PicassoV2_and_picasso_tutor_plugin/
I have already tried it with the following:
Extra
Consequence: I propose changing TUTOR_VERSION to
PICASSO_TUTOR_VERSION
because we will need something to have different versions of the compile.