Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DS-223-feat: use faster config for theming config at eox-tenant #26

Merged
merged 1 commit into from
Sep 9, 2022
Merged

DS-223-feat: use faster config for theming config at eox-tenant #26

merged 1 commit into from
Sep 9, 2022

Conversation

JuanDavidBuitrago
Copy link
Member

Description:

This PR adds EOX_THEMING_CONFIG_SOURCES key in plugin, to use faster config for theming config at eox-tenant.

How to test

  1. Clone the repo and change the branch.
 git clone [email protected]:eduNEXT/tutor-contrib-edunext-distro.git
 cd tutor-contrib-edunext-distro
 git chechout JDB/faster_config_for_theming
  1. In your environment, install the plugin.
 pip install -e PATH_TO_DISTRO_PLUGIN
  1. Check EOX_THEMING_CONFIG_SOURCES key. Go to env/apps/openedx/settings/<cms|lms> in production.py and development.py files.
  2. Check eox-themming version in <lms-path>/eox-theming/eox-info, it has to be "3.1.0"

@JuanDavidBuitrago JuanDavidBuitrago added the enhancement New feature or request label Sep 8, 2022
@JuanDavidBuitrago JuanDavidBuitrago self-assigned this Sep 8, 2022
@JuanDavidBuitrago JuanDavidBuitrago linked an issue Sep 8, 2022 that may be closed by this pull request
[FEAT] use faster config for theming config at eox-tenant #23
Closed
@JuanDavidBuitrago JuanDavidBuitrago merged commit 8029fae into master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Henrrypg Henrrypg Henrrypg approved these changes

@dcoa dcoa dcoa approved these changes

@danielsgz danielsgz danielsgz approved these changes

@MaferMazu MaferMazu Awaiting requested review from MaferMazu

@Alec4r Alec4r Awaiting requested review from Alec4r

Assignees

@JuanDavidBuitrago JuanDavidBuitrago

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] use faster config for theming config at eox-tenant
4 participants
@JuanDavidBuitrago @Henrrypg @dcoa @danielsgz