feat: allow to run multiple celery queues and workers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian2012
force-pushed
the
cag/celery-queue
branch
from
0c34ee1 to
ad0a4b0
Compare
jfavellar90
reviewed
Jul 2, 2024
jfavellar90
reviewed
Jul 2, 2024
jfavellar90
reviewed
Jul 3, 2024
|
@Ian2012 I remain attentive to the results of the tests adding LMS tasks to CMS configuration (via EXPLICIT_QUEUES) and vice-versa |
|
@jfavellar90 Mixing the settings for the tasks routes can cause different issues, I've decided to create two separate variables to control LMS and CMS workers tasks routing. |
jfavellar90
reviewed
Jul 10, 2024
README.md
Outdated
| - cms_custom_queue | ||
| ``` | ||
|
|
||
| This plugin also provides a setting to directly route LMS/CMS tasks to an specific queue: |
There was a problem hiding this comment.
I think it's important to mention that this will extend/override the variable EXPLICIT_QUEUES on both LMS and CMS
jfavellar90
approved these changes
Jul 10, 2024
|
I already provided my approval @Ian2012, however, please fix the minor detail I mentioned in my last comment and proceed with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the deployment of multiple celery queues and workers via settings. It also overrides the default lms-worker deployment to prevent it to consume events from all queues.
Deployed on
musashi/tunisFuture work
geventpool (installgeventon openedx via this plugin)