Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enrollment request form changes #36

Merged
merged 10 commits into from
Sep 1, 2023

Conversation

julianramirez2
Copy link
Contributor

Description

All necessary adjustments to the enrollments form have been completed:

  • Verification of the Course ID field, always requiring the 'course-v1' prefix.
  • Tooltips added to the Enrollment Request fields.
  • Form redesign.
  • Logs located at the bottom

Each action, both for the checkboxes and the buttons (Save Locally, Sync, and Send to API), has been properly refactored to indicate the correct action.

Additional information

This is how the front-end looks like:

image

And this is how the tooltip looks like:

image

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

MaferMazu
MaferMazu previously approved these changes Sep 1, 2023
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @julianramirez2, can you double-check my changes?
Do we want to add the phpcs-report.xml in our .gitignore?

@andres-arango-aptitude, what do you think about this PR?

Copy link

@andres-arango-aptitude andres-arango-aptitude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good to me

@julianramirez2
Copy link
Contributor Author

Looks good to me. @julianramirez2, can you double-check my changes? Do we want to add the phpcs-report.xml in our .gitignore?

@andres-arango-aptitude, what do you think about this PR?

Looks good to me. @julianramirez2, can you double-check my changes? Do we want to add the phpcs-report.xml in our .gitignore?

@andres-arango-aptitude, what do you think about this PR?

Looks good to me, and yes, it's better if we include the phpcs-report.xml in the gitignore file.

@julianramirez2 julianramirez2 merged commit 66e2643 into main Sep 1, 2023
@felipemontoya felipemontoya deleted the enrollment-form-design branch March 21, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants