Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ORA filter for submission view rendering intervention #1

Closed
wants to merge 1 commit into from

Conversation

BryanttV
Copy link

@BryanttV BryanttV commented Feb 6, 2024

Description

This PR adds a filter to modify the default template of submissions in an ORA assignment.

  • New filter: ORASubmissionViewRenderStarted
  • New exception: RenderInvalidTemplate

@BryanttV BryanttV marked this pull request as ready for review February 6, 2024 22:54
@BryanttV BryanttV changed the title feat: add ORA filter for student_view rendering intervention feat: add ORA filter for submission view rendering intervention Feb 6, 2024
Copy link
Collaborator

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! With or without context, it's fine. Thank you!

@BryanttV BryanttV force-pushed the bav/ora-student-view-filter branch 3 times, most recently from ace5e58 to 01b3042 Compare April 10, 2024 21:47
@BryanttV BryanttV force-pushed the bav/ora-student-view-filter branch 3 times, most recently from ecc6947 to 6c0e69c Compare April 11, 2024 21:01
@BryanttV BryanttV force-pushed the bav/ora-student-view-filter branch from 6c0e69c to 224bcf3 Compare April 11, 2024 22:39
@BryanttV
Copy link
Author

These changes are already in master 💯

@BryanttV BryanttV closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants