Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MFE configuration at runtime (#335) #4

Merged

Conversation

andrey-canon
Copy link

Description:

Backport of openedx#335

johanseto
johanseto previously approved these changes Jan 30, 2023
Copy link

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried and the code is working. Mainly by this is a backport.

@andrey-canon andrey-canon force-pushed the and/backport_runtime_configuration branch from 9558dcd to e8a5032 Compare February 1, 2023 19:57
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (ednx-release/mango.nelp@437c8d7). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@                    Coverage Diff                     @@
##             ednx-release/mango.nelp       #4   +/-   ##
==========================================================
  Coverage                           ?   81.51%           
==========================================================
  Files                              ?       38           
  Lines                              ?      898           
  Branches                           ?      164           
==========================================================
  Hits                               ?      732           
  Misses                             ?      155           
  Partials                           ?       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrey-canon andrey-canon changed the base branch from ednx-release/mango.nelp to master February 1, 2023 20:02
@andrey-canon andrey-canon dismissed johanseto’s stale review February 1, 2023 20:02

The base branch was changed.

@andrey-canon andrey-canon changed the base branch from master to ednx-release/mango.nelp February 1, 2023 20:03
@andrey-canon andrey-canon merged commit 9372490 into ednx-release/mango.nelp Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants