forked from openedx/frontend-app-authoring
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: add support of css-variables to redwood #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…penedx#1055) * fix: update date using utc timezone instead of local * fix: lint error Co-authored-by: Kristin Aoki <[email protected]>
Co-authored-by: Kristin Aoki <[email protected]>
* fix: allow grace period minutes only * fix: zero minutes error Co-authored-by: Kristin Aoki <[email protected]>
…nedx#1069) This change fixes redirection to the library component in the unit when selecting the search result. It also fixes an issue with navigating to the library MFE when selecting a library component.
…penedx#1057) * Hide language taxonomy when empty * New message on search result when taxonomy is empty * Empty taxonomies message added in drawer
…nedx#1075) Co-authored-by: Kristin Aoki <[email protected]>
The primary purpose of this version bump backport is to remove the 2U feedback form link from the editors (openedx/frontend-lib-content-components#476), but several other improvements will also be pulled in: * Fix the Text editor so that when an image is added, it is added at the cursor, instead of the beginning of the component. * Improve editor load time by reducing API calls and switching some calls to be lazy. * Align controls better in the group feedback component. * Add validation for start & stop date fields. * Fix image handling bugs in both the raw & visual text editors. Full changelog: openedx/frontend-lib-content-components@v2.1.11...v2.5.1 Co-authored-by: Kyle McCormick <[email protected]>
bra-i-am
force-pushed
the
bc/update-redwood
branch
from
August 5, 2024 21:30
bb78cca
to
28e914a
Compare
dcoa
approved these changes
Aug 7, 2024
Please don't make a merge or squash commit instead apply reverse and merge to integrate the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds compatibility of runtime theming to Redwood.
To solve the test issues it was necessary to backport this upstream fix:
How to test
Go to the course authoring of the Stage and navigate it. The styles should be consistent along the section and every part should work properly.
Note
The tests are failing because it is lacking a Codecov token
JIRA ISSUE AP-1169