Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add support of css-variables to redwood #5

Merged
merged 13 commits into from
Aug 9, 2024

Conversation

bra-i-am
Copy link

@bra-i-am bra-i-am commented Aug 1, 2024

Description

This PR adds compatibility of runtime theming to Redwood.

To solve the test issues it was necessary to backport this upstream fix:

How to test

Go to the course authoring of the Stage and navigate it. The styles should be consistent along the section and every part should work properly.

Note

The tests are failing because it is lacking a Codecov token

JIRA ISSUE AP-1169

GlugovGrGlib and others added 11 commits May 29, 2024 09:46
…penedx#1055)

* fix: update date using utc timezone instead of local

* fix: lint error

Co-authored-by: Kristin Aoki <[email protected]>
* fix: allow grace period minutes only

* fix: zero minutes error

Co-authored-by: Kristin Aoki <[email protected]>
…nedx#1069)

This change fixes redirection to the library component in the unit when selecting the search result. It also fixes an issue with navigating to the library MFE when selecting a library component.
…penedx#1057)

* Hide language taxonomy when empty
* New message on search result when taxonomy is empty
* Empty taxonomies message added in drawer
The primary purpose of this version bump backport is to remove the 2U feedback form
link from the editors (openedx/frontend-lib-content-components#476),
but several other improvements will also be pulled in:

* Fix the Text editor so that when an image is added, it is added at the cursor,
  instead of the beginning of the component.
* Improve editor load time by reducing API calls and switching some calls to be lazy.
* Align controls better in the group feedback component.
* Add validation for start & stop date fields.
* Fix image handling bugs in both the raw & visual text editors.

Full changelog: openedx/frontend-lib-content-components@v2.1.11...v2.5.1

Co-authored-by: Kyle McCormick <[email protected]>
@bra-i-am bra-i-am requested a review from dcoa August 1, 2024 14:14
@bra-i-am bra-i-am force-pushed the bc/update-redwood branch from bb78cca to 28e914a Compare August 5, 2024 21:30
@dcoa
Copy link

dcoa commented Aug 7, 2024

Please don't make a merge or squash commit instead apply reverse and merge to integrate the changes.

@bra-i-am bra-i-am merged commit 580ad66 into ednx-release/redwood.master Aug 9, 2024
2 of 3 checks passed
@bra-i-am bra-i-am deleted the bc/update-redwood branch August 9, 2024 14:26
@bra-i-am bra-i-am restored the bc/update-redwood branch August 9, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants