-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(FFI-3/DS-300) filter user's course enrollment by microsite request #156
Conversation
9deaf81
to
37bde3e
Compare
37bde3e
to
6d4fbaf
Compare
@JuanDavidBuitrago please, can you create a readme file in the filters folder with docs about what filters contain and what is the objective of each one? thanks. And also, I think that maybe the folder should have like name "pipelines" instead of "filters" and inside 1 file per pipeline, because the filters are in openedx-filter, right? or just use the file pipelines.py and remove the folder. Why? Because in a future we want to order each eox-* by bounded context. |
814544c
to
18264d1
Compare
18264d1
to
559396e
Compare
@Alec4r, I added a readme file. The pipeline inside of filters folder is a custom filter step, for that reason I named it like this, In openedx-filters there is only a filter structure that can be used from edx-platform. The idea is to add new filter steps in this folder, and I consider we should use this space to related with openedx-filters. For example, a Mafer's card has to implement a filter here. FYI: eox-tenant already has a pipeline outside filter folder, but differ with the intention of filter steps pipelines: https://github.com/eduNEXT/eox-tenant/blob/master/eox_tenant/pipeline.py Let me know what do you think with this feedback. |
This file is a third party auth pipeline https://github.com/eduNEXT/eox-tenant/blob/master/eox_tenant/pipeline.py ... maybe we need think in rename it, but we can do it in a future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was already tested, Good job!
Description
This PR adds a custom filter pipeline to get course enrollments from tenant site where a user makes the request.
The idea is including some changes in openedx-filters and edx-platform repositories to anyone implement the filter function, and one clear example to use is this custom pipeline on eox-tenant plugin.
Dependencies for now:
Future dependencies:
Testing instructions
Mobile Course Available
true. Go on to configure the key: studio.nutmeg.edunext.link:8001/settings/advanced/{your_course_id}OPEN_EDX_FILTERS_CONFIG
in your site, the request show all courses.Additional information
Checklist for Merge