Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration tests for the support api AP-1527 #300

Merged
merged 34 commits into from
Nov 15, 2024

Conversation

BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Oct 30, 2024

Description

This PR adds integration tests for the support API. These tests are executed in the job of Tutor Integration Tests

Testing instructions

Check the jobs of Tutor Integration Tests in the PR.

Jira Issue

.coveragerc Outdated Show resolved Hide resolved
@BryanttV BryanttV force-pushed the bav/support-api-integration-tests branch 2 times, most recently from 13eada3 to f947dfe Compare November 6, 2024 20:47
@BryanttV BryanttV requested a review from magajh November 6, 2024 22:05
@BryanttV BryanttV marked this pull request as ready for review November 6, 2024 22:05
@BryanttV BryanttV requested a review from a team as a code owner November 6, 2024 22:05
@BryanttV BryanttV force-pushed the bav/support-api-integration-tests branch from 2a6408c to 16f0cfe Compare November 7, 2024 16:24
@mariajgrimaldi
Copy link
Contributor

LGTM, I have an additional comment for you to address: #300 (comment). Let me know once you do to leave my approval :)

Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @BryanttV! just have one comment about the extra commands script

scripts/execute_tutor_extra_commands.sh Show resolved Hide resolved
.github/workflows/integration-test.yml Outdated Show resolved Hide resolved
magajh
magajh previously approved these changes Nov 12, 2024
Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BryanttV tag me if you need my approval again

@BryanttV BryanttV requested a review from magajh November 12, 2024 20:26
@BryanttV BryanttV force-pushed the bav/support-api-integration-tests branch from c3de7db to cca23f4 Compare November 12, 2024 22:05
@BryanttV
Copy link
Contributor Author

Hi @magajh @mariajgrimaldi, I made the last changes in the PR.

@BryanttV BryanttV force-pushed the bav/support-api-integration-tests branch from 49b8a0d to 586f62c Compare November 13, 2024 17:48
@BryanttV BryanttV merged commit 1b27a71 into master Nov 15, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants