Revert "feat: add register intent prop for login segement call (opene…

…dx#34891)" (openedx#35021)

This reverts commit a2aa6bd.

openedx/core/djangoapps/user_authn/views/login.py

@@ -363,15 +363,13 @@ def _track_user_login(user, request):
             'MailChimp': False
         }
     )
-    register_intent = request.POST.get('register_intent') == 'true'
     segment.track(
         user.id,
         "edx.bi.user.account.authenticated",
         {
             'category': "conversion",
             'label': request.POST.get('course_id'),
-            'provider': None,
-            'register_intent': register_intent,
+            'provider': None
         },
     )
 

openedx/core/djangoapps/user_authn/views/tests/test_login.py

@@ -1041,7 +1041,6 @@ class LoginSessionViewTest(ApiTestCase, OpenEdxEventsTestMixin):
     USERNAME = "bob"
     EMAIL = "[email protected]"
     PASSWORD = "password"
-    REGISTER_INTENT = 'true'
 
     @classmethod
     def setUpClass(cls):
@@ -1118,7 +1117,6 @@ def test_login(self, include_analytics, mock_segment):
         data = {
             "email": self.EMAIL,
             "password": self.PASSWORD,
-            "register_intent": self.REGISTER_INTENT,
         }
         if include_analytics:
             track_label = "edX/DemoX/Fall"
@@ -1147,7 +1145,7 @@ def test_login(self, include_analytics, mock_segment):
         mock_segment.track.assert_called_once_with(
             expected_user_id,
             'edx.bi.user.account.authenticated',
-            {'category': 'conversion', 'provider': None, 'label': track_label, 'register_intent': True}
+            {'category': 'conversion', 'provider': None, 'label': track_label}
         )
 
     def test_login_with_username(self):