Merge main update #20
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request introduces several enhancements to the modulation functionalities within the library. It includes the renaming of functions to adhere to Python's naming conventions, the addition of new functions for generating various modulation constellations (PAM, QAM, PSK, APSK), and the introduction of a symbol detection function supporting both MAP and ML detection rules. Additionally, it extends the plotting capabilities with functions for plotting decision boundaries, generating constellation plot animations, and creating random colormaps. The changes aim to improve the library's usability, extend its functionality, and enhance its signal processing and visualization capabilities.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
- Big diff: the diff is too large to approve with confidence.
General suggestions:
- Ensure that the newly introduced padding parameter ('lpad') and its application do not introduce any unintended effects, especially in edge cases where signal alignment is crucial.
- Consider providing more detailed documentation or examples on how to use the new constellation generation functions and the symbol detection function, to help users integrate these enhancements into their projects effectively.
- Review the impact of the new plotting functions on the library's performance and usability, ensuring they align with the library's design principles and user expectations.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
|
|
||
| try: | ||
| Ei.shape[1] | ||
| except IndexError: | ||
| Ei = Ei.reshape(len(Ei), 1) | ||
|
|
||
| Ei = np.pad(Ei, ((0, lpad), (0, 0))) |
There was a problem hiding this comment.
question (llm): Applying zero padding as per the 'lpad' parameter is correctly implemented. However, ensure that this padding strategy aligns with the expected signal processing flow and does not introduce unintended artifacts or distortions.
No description provided.