Skip to content

Commit

Permalink
CI: reenable tests that are working again
Browse files Browse the repository at this point in the history
- containers#15074 ("subtree_control" flake). The flake is NOT FIXED, I
  saw it six months ago on my (non-aarch64) laptop. However,
  it looks like the frequent-flake-on-aarch64 bug is resolved.
  I've been testing in containers#17831 and have not seen it. So,
  tentatively remove the skip and see what happens.

- Closes: containers#19407 (broken tar, "duplicates of file paths")
  All Fedoras now have a fixed tar. Debian DOES NOT, but
  we're handling that in our build-ci-vm code. I.e., the
  Debian VM we're using has a working tar even though there's
  currently a broken tar out in the wild.

  Added distro-integration tag so we can catch future problems
  like this in OpenQA.

- Closes: containers#19471 (brq / blkio / loopbackfs in rawhide)
  Bug appears to be fixed in rawhide, at least in the VMs we're
  using now.

  Added distro-integration tag because this test obviously
  relies on other system stuff.

Signed-off-by: Ed Santiago <[email protected]>
  • Loading branch information
edsantiago committed Jan 16, 2024
1 parent 2981262 commit e66413b
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 13 deletions.
8 changes: 2 additions & 6 deletions test/system/125-import.bats
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,9 @@ load helpers
run_podman rmi -f $fqin
}

# Integration tag to catch future breakage in tar, e.g. #19407
# bats test_tags=distro-integration
@test "podman export, alter tarball, re-import" {
# Skip this only when running under rawhide in CI, since detecting
# and/or skipping for rawhide outside this environment is unhelpful.
if [[ "$CIRRUS_CI" == "true" ]] && [[ "$DISTRO_NV" == "rawhide" ]]; then
skip "FIXME: #19407 Broken in rawhide: processing tar file(): duplicates of file paths not supported"
fi

# Create a test file following test
mkdir $PODMAN_TMPDIR/tmp
touch $PODMAN_TMPDIR/testfile1
Expand Down
3 changes: 0 additions & 3 deletions test/system/180-blkio.bats
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ function teardown() {
}

@test "podman run --blkio-weight-device" {
# Broken on rawhide & F38 images as of c20230726t191046z-f38f37d13
skip "FIXME: #19471 brq / blkio / loopbackfs / something broken"

skip_if_rootless "cannot create devices in rootless mode"

# create loopback device
Expand Down
1 change: 0 additions & 1 deletion test/system/200-pod.bats
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,6 @@ spec:
skip_if_remote "resource limits only implemented on non-remote"
skip_if_rootless "resource limits only work with root"
skip_if_cgroupsv1 "resource limits only meaningful on cgroups V2"
skip_if_aarch64 "FIXME: #15074 - flakes often on aarch64"

# create loopback device
lofile=${PODMAN_TMPDIR}/disk.img
Expand Down
4 changes: 1 addition & 3 deletions test/system/280-update.bats
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@ function teardown() {
}


# bats test_tags=distro-integration
@test "podman update - test all options" {
# Broken on rawhide & F38 images as of c20230726t191046z-f38f37d13
skip "FIXME: #19471 brq / blkio / loopbackfs / something broken"

local cgv=1
if is_cgroupsv2; then
cgv=2;
Expand Down

0 comments on commit e66413b

Please sign in to comment.