Skip to content

Commit

Permalink
System test for containers#9096 (truncated stdout)
Browse files Browse the repository at this point in the history
This actually tests conmon, not podman; but that's the whole
point of system tests in the first place: if a problem exists,
we want to fail loudly, no matter whose fault it is.

(I can't get this to fail on my f33 laptop; OP on containers#9096 claims
it only fails on Ubuntu. We'll see what happens in CI).

Signed-off-by: Ed Santiago <[email protected]>
  • Loading branch information
edsantiago committed Feb 3, 2021
1 parent d1e0afd commit 1c50e09
Showing 1 changed file with 39 additions and 0 deletions.
39 changes: 39 additions & 0 deletions test/system/030-run.bats
Original file line number Diff line number Diff line change
Expand Up @@ -610,4 +610,43 @@ json-file | f
is "$output" "$randomcontent" "cat random content"
}

# https://github.com/containers/podman/issues/9096
# podman exec may truncate stdout/stderr; actually a bug in conmon:
# https://github.com/containers/conmon/issues/236
@test "podman run - does not truncate or hang with big output" {
# Size, in bytes, to dd and to expect in return
char_count=700000

# Container name; primarily needed when running podman-remote
cname=mybigdatacontainer

# This is one of those cases where BATS is not the best test framework.
# We can't do any output redirection, because 'run' overrides it so
# as to preserve $output. We can't _not_ do redirection, because BATS
# doesn't like NULs in $output (and neither would humans who might
# have to read them in an error log).
# Workaround: write to a log file, and don't attach stdout.
run_podman run --name $cname --attach stderr --log-driver k8s-file \
$IMAGE dd if=/dev/zero count=$char_count bs=1
is "${lines[0]}" "$char_count+0 records in" "dd: number of records in"
is "${lines[1]}" "$char_count+0 records out" "dd: number of records out"

# We don't have many tests for '-l'. This is as good a place as any
if ! is_remote; then
cname=-l
fi

# Now find that log file, and count the NULs in it.
# The log file is of the form '<timestamp> <P|F> <data>', where P|F
# is Partial/Full; I think that's called "kubernetes log format"?
run_podman inspect $cname --format '{{.HostConfig.LogConfig.Path}}'
logfile="$output"

count_zero=$(tr -cd '\0' <$logfile | wc -c)
is "$count_zero" "$char_count" "count of NULL characters in log"

# Clean up
run_podman rm $cname
}

# vim: filetype=sh

0 comments on commit 1c50e09

Please sign in to comment.