Skip to content

Commit

Permalink
System tests: reenable once-flaky exec + stty test
Browse files Browse the repository at this point in the history
Ref: containers#10710, a nasty and frequent flake. I can no longer
reproduce the failure on f35 or Rawhide, so let's take
the risk of reenabling the test.

Signed-off-by: Ed Santiago <[email protected]>
  • Loading branch information
edsantiago committed Feb 23, 2022
1 parent 0d2bd53 commit 1895cde
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions test/system/450-interactive.bats
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,17 @@ function teardown() {

run_podman rm -t 0 -f mystty

# FIXME: the checks below are flaking a lot (see #10710).

# check that the same works for podman exec
# run_podman run -d --name mystty $IMAGE top
# run_podman exec -it mystty stty size <$PODMAN_TEST_PTY
# is "$output" "$rows $cols" "stty under podman exec reads the correct dimensions"
#
# run_podman rm -t 0 -f mystty
# FIXME: 2022-02-23: these lines reenabled after months of flaking (#10710,
# "stty: standard input"). Ed can no longer reproduce the failure, so
# we'll try to reenable. If the flake recurs, just comment out all the
# lines below. If it is July 2022 or later, and the flake is gone,
# please remove this comment.
run_podman run -d --name mystty $IMAGE top
run_podman exec -it mystty stty size <$PODMAN_TEST_PTY
is "$output" "$rows $cols$CR" "stty under podman exec reads the correct dimensions"

run_podman rm -t 0 -f mystty
}


Expand Down

0 comments on commit 1895cde

Please sign in to comment.