Skip to content

Commit

Permalink
Bump nippy to 3.1.1 w/ fix for breaking change
Browse files Browse the repository at this point in the history
Versions after 2.14.0 required a breaking change due to security
advisories (see taoensso/nippy#130). The
fix requires explicit declaration of the types that are safe to
thaw.
  • Loading branch information
edporras committed Aug 13, 2021
1 parent 615555e commit 3e00784
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion project.clj
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
[org.apache.beam/beam-runners-google-cloud-dataflow-java "2.26.0"]
[org.apache.beam/beam-runners-core-java "2.26.0"]
[org.apache.kafka/kafka-clients "2.5.0"]
[com.taoensso/nippy "2.14.0"]
[com.taoensso/nippy "3.1.1"]
[org.clojure/math.combinatorics "0.1.6"]
[org.clojure/tools.logging "1.1.0"]
[clj-time "0.15.2"]
Expand Down
4 changes: 4 additions & 0 deletions src/clj/datasplash/core.clj
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,10 @@ See https://cloud.google.com/dataflow/java-sdk/JavaDoc/com/google/cloud/dataflow
[^DoFn$ProcessContext c]
(.output c (.element c)))

(alter-var-root #'nippy/*thaw-serializable-allowlist*
(fn [_] (into nippy/default-thaw-serializable-allowlist
#{"org.apache.beam.sdk.values.KV"})))

(defn make-nippy-coder
{:doc "Returns an instance of a CustomCoder using nippy for serialization"
:added "0.1.0"}
Expand Down

0 comments on commit 3e00784

Please sign in to comment.