removing pkg-resources requirements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems to be an Ubuntu quirk with pip
…ces" This reverts commit c55bed6. No longer needed
|
I have added another regex into the numify function which provides support for the new format of referencing used (which is the OSIS system). We are in a transition phase at the moment but both ITSEE and INTF will be moving to this referencing system for both transcriptions and collations. Support for the old one is still in the code so older format data will still work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pip install git+ installation doesn't work with pkg-resources in the requirements. I have removed it from requirements.txt and the setup script which seems to be enough to make it work.