Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cached parser #51

Merged
merged 2 commits into from
Feb 14, 2020
Merged

cached parser #51

merged 2 commits into from
Feb 14, 2020

Conversation

greut
Copy link
Member

@greut greut commented Feb 11, 2020

This addresses the #30 issue. It proposes a cache for the .editorconfig definition

master branch running on https://github.com/dotnet/roslyn

$ time editorconfig $(git ls-files) | wc -l
680099

real    0m7.575s
user    0m8.568s
sys     0m0.764s

this branch

$ time editorconfig $(git ls-files) | wc -l
680099

real    0m1.862s
user    0m1.912s
sys     0m0.402s

Previous discussions were made under #48 - Kudos go to @andreynering for the useful reviews and feedbacks.

Signed-off-by: Yoan Blanc <[email protected]>
Copy link
Contributor

@andreynering andreynering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great! 👏

Just a TODO comment missing

Thanks! 😉

definition.go Show resolved Hide resolved
Signed-off-by: Yoan Blanc <[email protected]>
@greut greut merged commit 9b383fd into editorconfig:master Feb 14, 2020
@greut greut deleted the loader branch May 18, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants