Skip to content
This repository has been archived by the owner on Dec 8, 2020. It is now read-only.

Added "rust.rustup.nightlyToolchain". #299

Merged
merged 2 commits into from
Jun 24, 2017

Conversation

KalitaAlexey
Copy link
Member

Fixes #295
Fixes #281
Fixes #294
Fixes #280

@KalitaAlexey
Copy link
Member Author

I hope this time I will not introduce any other issues.

@KalitaAlexey KalitaAlexey merged commit 5442989 into master Jun 24, 2017
@KalitaAlexey KalitaAlexey deleted the add-nightly-toolchain-parameter branch June 24, 2017 06:22
@raggi
Copy link
Contributor

raggi commented Jul 5, 2017

Is there a way this parameter could be made to be portable? I use the same vscode configuration across multiple platforms, and I would like for this option not to have to change. Maybe if it could have a priority ordered list that matches against what is installed?

@KalitaAlexey
Copy link
Member Author

No sorry. You have to choose it at least once.

@KalitaAlexey
Copy link
Member Author

It introduces a complication which has a very little benefit

@raggi
Copy link
Contributor

raggi commented Jul 5, 2017

ok, I guess the best thing for now is to duplicate this in workspace settings. thanks for the prompt reply!

@KalitaAlexey
Copy link
Member Author

@raggi,
Yeah the extension sets the global value. You can set the workspace value if it suits you.

@raggi
Copy link
Contributor

raggi commented Aug 2, 2017

@KalitaAlexey I've been living with this for a month or so now, and I can safely say that I want something better. It's really annoying having to constantly revert changes it makes to my global config and having to manually go and add settings to my project configs. I have a rustup default set, and I'd really strongly prefer it just used that unless overridden, as a default, and then if it needs to set something, it should be set in the project config first, not global config. I think I understand why you want it in global config - and that's cool, but I'd really appreciate an option to stop it from doing that, due to the aforementioned frustrations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants