Declare compatibility with Ruby 3.x in addition to 2.x #1
Conversation
|
Hello, This looks fine so far, I will probably merge it soon. At the moment, I have not yet installed Ruby 3.0, but plan to do so shortly as I have another project that could use it. Would you like to be a committer/collab on this project? It was started because as I am a blind developer, I needed some custom output formatting from MiniTest. that I could plug into my custom IDE. Let me know, Ed |
|
Hi Ed, I'd be happy to help out if I can, I don't have a huge amount of time available to dedicate to this, but I'd be happy to do some of that TLC that's needed. Let me know what needs working on! Have you had a chance to take a look at this, by the way? My other dependencies have all resolved their Ruby 3.0 compatibility issues, so it's just this one left for me. Thanks! |
|
Hi @edhowland just wondering if you're planning on maintaining this and bumping it up to Ruby support beyond 3.0. Everything seems to work okay with Ruby 3.1.1. |
|
I could provide a PR with a setup for github actions so it's easy to test against multiple Ruby versions. |
| @@ -19,7 +19,7 @@ See: https://atom.io. Originally written to interface with the Viper Audible edi | |||
| spec.bindir = 'exe' | |||
| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | |||
| spec.require_paths = ['lib'] | |||
| spec.required_ruby_version = '~> 2.0' | |||
| spec.required_ruby_version = '>= 2.0', '<= 3.0' | |||
There was a problem hiding this comment.
This makes it work with 2.x and 3.0, but not 3.1 or newer.
To include all of 2.x and 3.x we'd need: '>= 2.0', '< 4.0'
|
Hi everyone,
Just got this while I was away on vacation.
I haven't yet gone into GH to check on PRs.
Was one issued for this change to work with Ruby 3.1 and beyond?
If so, I'll probably give it my approval and merge it.
Thanks, Ed
This missive is from me and no one else. If you got this message and you
are not you, then that is your problem and not mine.
…On Mon, Jul 8, 2024 at 11:40 AM Thomas Thomassen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In minitest-reporters-json_reporter.gemspec
<#1 (comment)>
:
> @@ -19,7 +19,7 @@ See: https://atom.io. Originally written to interface with the Viper Audible edi
spec.bindir = 'exe'
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ['lib']
- spec.required_ruby_version = '~> 2.0'
+ spec.required_ruby_version = '>= 2.0', '<= 3.0'
This makes it work with 2.x and 3.0, but not 3.1 or newer.
To include all of 2.x and 3.x we'd need: '>= 2.0', '< 4.0'
—
Reply to this email directly, view it on GitHub
<#1 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAHXZA2OD36UGXPZ37QIMLZLKXGFAVCNFSM6AAAAABKRCY2A2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRTG4YTKOJWGQ>
.
You are receiving this because you were mentioned.Message ID:
<edhowland/minitest-reporters-json_reporter/pull/1/review/2163715964@
github.com>
|
With this change, I believe this gem works with Ruby 3. All tests pass, and I've tried using the gem with this change with a Rails app under Ruby 3.0.0, and it worked.