-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returning to the project, new todo list #33
Comments
So, my brain is mashed potato right now (did not sleep yet, just finished Half-Life: Alyx, I'm processing what happened yet because OMFG) Point by point, here's what I think:
|
do you mean "I see no reason to support C++14", or "I see no reason not to support C++14" ? |
I mean, I see no reason to support the older |
Can you add a small hint in wiki for those using Visual Studio: With this flag set to default you get a bunch of errors, since it is not supporting C++ < 17. |
@szejos Now that you say that, I thought that it was clearly stated that this library was written in C++17. But it seems that it's not the case... I will add a mention to the README.md file! 😄 As a side note, If you use CMake, you can take inspiration on how we include the library for our CI/Examples. This sets the flags automatically for all compilers that supports it https://github.com/Edhebi/cpp-sdl2/blob/master/examples/CMakeLists.txt#L3 |
Thanks, @Ybalrid. Note that this will be less of an issue when get a proper cmake configuration. |
|
I'd like to see this in MSYS2, although I think there would be a problem with cmake, as the current cmake files for SDL2 on MSYS won't link unless SDL_MAIN_HANDLED is defined. |
Haven't been active on this project for a while, so here are a few things to keep me occupied for a bit, in no particular order:
Fix the
Event::EventFilter
mess. It's overengineered, messy, and most definetly out of scope. Removal might be the best thing to do here.Add tests. I'm still not sure how to format them, but it'd be good to have them. This includes unit tests, static analysis, more warnings, sanitizers, whatever makes sence for us.
Have a root cmake file to automate stuff. Three reasons:
Should we go as far as setting up a package manager ? I realy like conan, but I'm not sure of the gain.
Doxygen is ugly af, and definetly not a pleasure to navigate. That being said, I don't know enough about the other options to have a real opinion. Let's look at what the community does.
Maybe not do everything in a single master branch ? It's not a problem now, but it's not ideal either.
Should we support c++ <17 ? This seems to imply macros and preprocessor to still take advantage of recent features when available, and I don't like the sound of it.
Those points are open to debate and some need conversation. Feel free to butt in and say stuff (looking at you, @Ybalrid :p). To me, those are the things to fix before a real
1.0.0
release tag.The text was updated successfully, but these errors were encountered: