Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hackney version #394

Merged
merged 3 commits into from
Sep 30, 2019
Merged

Update Hackney version #394

merged 3 commits into from
Sep 30, 2019

Conversation

perrycate
Copy link
Contributor

Per benoitc/hackney#591, hackney 1.15.2 fixes
the "honor_cipher_order' issue present when sending https requests on
OTP 22.1

Per benoitc/hackney#591, hackney 1.15.2 fixes
the "honor_cipher_order' issue present when sending https requests on
OTP 22.1
@edgurgel
Copy link
Owner

@perrycate, thanks for the PR! Would you mind including the requirement to be greater than 1.15.2 just so people don't try to use 1.15.1 for example (unless they override ofc)?

Something like "~> 1.15 and >= 1.15.2" I think?

@edgurgel
Copy link
Owner

Sorry @perrycate , but simply using >= will accept 2.0 for example which we don't necessarily want. That's why I proposed "~> 1.15 and >= 1.15.2" so that it will still respect ~>

@perrycate
Copy link
Contributor Author

Oooh I see. Sorry, I'm still learning the syntax, I didn't realize 'and' was a valid keyword. Will fix in a moment, and thanks for explaining it to me!

@edgurgel
Copy link
Owner

@perrycate no worries! It's pretty impressive what it can do: https://hexdocs.pm/elixir/Version.html 🎉

@edgurgel edgurgel merged commit be85072 into edgurgel:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants