Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX: Reflect origin header for CORS auth #126

Merged
merged 2 commits into from
Aug 20, 2017
Merged

HOTFIX: Reflect origin header for CORS auth #126

merged 2 commits into from
Aug 20, 2017

Commits on Aug 20, 2017

  1. HOTFIX: reflect origin headers to allow auth 

    I broke remote authentication in e70230a. An upgrade to rack-cors changed the behavior of `origins '*'`
such that it now does not reflect the request's origin and instead actually sends '*' for the allowed origins header. That means authentication on our requests fails :(

See this change in rack-cors: cyu/rack-cors#142

We needed this behavior initially because it seemed like `Authorization` headers in our requests were getting stripped, but it seems like this may no longer be true. That needs more testing, though. For now, force rack-cors to return to its earlier behavior.

 Please enter the commit message for your changes. Lines starting
    @Mr0grog
    Mr0grog committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    ad560ad View commit details
    Browse the repository at this point in the history

  2. Add notes and FIXME comment about cors origins

    @Mr0grog
    Mr0grog committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    951ff6b View commit details
    Browse the repository at this point in the history