bug(race): Fixed races #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Forster <[email protected]>
brandonforster
force-pushed
the
issue_35
branch
from
e4b82c3 to
837193e
Compare
brandonforster
changed the title
|
@lenny-intel @rsdmike Any updates on this PR? |
| @@ -6,4 +6,4 @@ test: | |||
| $(GO) test ./... -coverprofile=coverage.out ./... | |||
| $(GO) vet ./... | |||
| gofmt -l . | |||
| [ "`gofmt -l .`" = "" ] | |||
There was a problem hiding this comment.
shouldn't -race be added to the test line?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We do not currently make use of the built in Go race detector.
Issue Number: Addressed as part of #35
What is the new behavior?
We make use of the built in Go race detector.
Does this PR introduce a breaking change?
Are there any specific instructions or things that should be known prior to reviewing?
Other information