fix: fix node labels #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuo
approved these changes
Aug 14, 2023
|
@wuxs 这个 pr 适合提给上游吗 |
|
这个是去掉 iptable-manager产生的，它们需要一起提交给上游 |
|
去掉 iptable-manager 是个比较大的变化，如果要合并到上游需要先给上游开个 issue，写proposal的简介和原理，如果上游同意了再写个具体的 proposal 的文档。之后才是提代码的 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #https://github.com/kubesphere/issues/issues/1673
Special notes for your reviewer:
Does this PR introduce a user-facing change?: