Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples to Gramine v1.7 #599

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

daniel-weisse
Copy link
Member

@daniel-weisse daniel-weisse commented Feb 27, 2024

Gramine released v1.7 a while ago, but this wasn't picked up by renovate since they also changed the tag format used for the images.

Proposed changes

  • Update samples to use Gramine v1.7
    • Run chmod on start.sh to fix potential issue when building container image
    • Use --insecure flag to check status of Coordinator before manifest is set
  • Remove mention of exact Gramine version in sample Readmes, we test against the latest Gramine version in our CI anyways

Additional info

  • Tested changes manually on Gramine v1.7
  • New redis image needs to be build after this PR is merged

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for marblerun-docs canceled.

Name Link
🔨 Latest commit e07eee0
🔍 Latest deploy log https://app.netlify.com/sites/marblerun-docs/deploys/66b3780a2e38ed0008f6e8c5

@daniel-weisse daniel-weisse changed the title Update samples to Gramine v1.6.1 Update samples to Gramine v1.6 Mar 20, 2024
@daniel-weisse daniel-weisse changed the title Update samples to Gramine v1.6 Update samples to Gramine v1.7 Aug 7, 2024
Signed-off-by: Daniel Weiße <[email protected]>
@daniel-weisse daniel-weisse merged commit e742325 into master Aug 8, 2024
5 of 6 checks passed
@daniel-weisse daniel-weisse deleted the deps/update-gramine branch August 8, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants